Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env var to configure announcement modal button text #2195

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Apr 10, 2023

Problem

The button text on the announcement modal is fixed to "Try me now", but we want it to be configurable

Solution

Add a new env var ANNOUNCEMENT_BUTTON_TEXT that allows configuration of the announcement modal's button text. If not set, the button's text will default back to "Try me now".

Also changed width to minWidth on the button styling, since the button text could overshoot the width limit and be wrapped across multiple lines, which we probably don't want?

Before & After Screenshots

BEFORE:
Screenshot 2023-04-10 at 1 46 31 PM

AFTER:
Screenshot 2023-04-10 at 1 45 29 PM

Tests

  • Test it on staging, after adding ANNOUNCEMENT_BUTTON_TEXT

Deploy Notes

New environment variables:

  • ANNOUNCEMENT_BUTTON_TEXT (optional): button text on the announcement modal

Copy link
Contributor

@thanhdatle thanhdatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@halfwhole halfwhole merged commit b22f4cf into develop Apr 12, 2023
@halfwhole halfwhole deleted the feat/announcement-modal-button-text branch April 12, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants