feat: add env var to configure announcement modal button text #2195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The button text on the announcement modal is fixed to "Try me now", but we want it to be configurable
Solution
Add a new env var
ANNOUNCEMENT_BUTTON_TEXT
that allows configuration of the announcement modal's button text. If not set, the button's text will default back to "Try me now".Also changed
width
tominWidth
on the button styling, since the button text could overshoot the width limit and be wrapped across multiple lines, which we probably don't want?Before & After Screenshots
BEFORE:
AFTER:
Tests
ANNOUNCEMENT_BUTTON_TEXT
Deploy Notes
New environment variables:
ANNOUNCEMENT_BUTTON_TEXT
(optional): button text on the announcement modal