Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update ubuntu to 22 in integration tests #2196

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

halfwhole
Copy link
Collaborator

@halfwhole halfwhole commented Apr 10, 2023

Problem

GitHub action for integration tests is not running because it's using Ubuntu 18.04, which is deprecated as of April 2023

This is blocking for any deployment/release because the build and deployment steps cannot happen before integration tests pass

Apologies, when merging in the integration tests PR #2091 (which was first opened before the ubuntu upgrade PR #2133), I didn't realise that the GitHub action was outdated

Solution

Bump Ubuntu version from 18.04 to 22.04

Copy link
Contributor

@thanhdatle thanhdatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halfwhole halfwhole merged commit 308b021 into develop Apr 12, 2023
@halfwhole halfwhole deleted the build/update-ubuntu-integration-tests branch April 12, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants