feat: announcement modal image for memos #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfwhole
changed the title
halfwhole
force-pushed
the
fix/announcement-modal-image-styling
branch
from
b820a4f to
938a579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to add the announcement modal image for memos
Also, the announcement modal image can be unnecessarily big or have lopsided proportions because the width and height are locked into specific values.
Solution
widthandheightfor the image tomaxWidthandmaxHeight, allowing either the actual width or height to be smaller in order to preserve image proportions.Before & After Screenshots
BEFORE:
AFTER:
