Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate email before passing through glob expression #2232

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix: validate email before passing through glob expression #2232

merged 1 commit into from
Jul 12, 2023

Conversation

halfwhole
Copy link
Collaborator

Problem

Possible ReDoS vulnerability on the frontend from glob email validations. Very low severity as it does not affect the backend

Closes Snyk issue

Solution

Ensure that the email is validated to be an actual email, before passing it into the glob expression matcher.

Tests

  • Tested manually locally, OTP logins still work

@thamsimun thamsimun requested review from gweiying and thanhdatle June 28, 2023 10:32
gweiying
gweiying approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@gweiying gweiying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@halfwhole halfwhole merged commit 752e4b3 into develop Jul 12, 2023
@halfwhole halfwhole deleted the fix/email-validator-frontend branch July 12, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweiying gweiying gweiying approved these changes

@thanhdatle thanhdatle Awaiting requested review from thanhdatle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halfwhole @gweiying