-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: front-end implementation for search phase 1 #227
Conversation
318cd37
to
5d301ca
Compare
aa5bb2e
to
a5e2642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the app and it seems OK. I would also suggest some UI tweaks, which you may wish to discuss with the designers:
- Removing the "sign in" button on search pages so that members of the public don't try and login, which will trigger 401 Unauthorized alarms
- Removing the "GoSearch" button when
IS_SEARCH_HIDDEN
is set tofalse
, as the search bar is already prominent - Adjust the CSS for the bottom banner so that it remains flush to the bottom on the search page
Resolved first and last issues. Iirc, the second was discussed with the designers before and it was a deliberate choice |
OK noted, @pearlyong FYI |
Problem
With the back-end implementation done, the public can now search for links through API calls. This PR implements the front-end UI for interacting with the search feature
Solution
Features:
src/client/util/config.ts
. IfIS_SEARCH_HIDDEN
is set to true, the only way to reach the search page is through a direct URL.IS_SEARCH_HIDDEN
is set to true in this PR.Improvements:
SearchResultsSortOrder
has been moved tosrc/shared/
as it is used by both the back and front-end codePaginationActionComponent
is now in the shared widgets folder due to it being used in both User page and Search pageSortPanel
has been extracted as a widget for the same reasonCollapsingPanel
has been extracted for the same reasonCloseIcon
,SearchIcon
andSearchSortIcon
are now resizable on IE11 and modern browsersCloseIcon
s should be closer in size to the design in all pagesLandingGraphicSliver
.BaseLayoutHeader
should use icons in mobile view instead of textBefore & After Screenshots
AFTER:
Integrated landing page (Desktop)
Integrated landing page (Mobile)
Search (Desktop)
Search (Mobile)
Search Info (Mobile)
Search Sort (Mobile)
Search Sort (Desktop)
Empty search (Desktop)
Empty search (Mobile)
Additional notes
TODO: