Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): update uuid, validator, request #228

Merged
merged 0 commits into from
Jun 30, 2020
Merged

build(deps): update uuid, validator, request #228

merged 0 commits into from
Jun 30, 2020

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Jun 30, 2020 •
edited
Loading

Problem/Solution

As part of efforts to keep the codebase fresh, perform the following:

  • Update uuid, validator, request and types to latest versions
  • Update googleAnalytics, shared/util/validation to align with
    changes in namespace
  • Replace request calls with cross-fetch in googleAnalytics

Tests

  • Validator should be exercised through logging in
  • uuid and cross-fetch should be verified by ensuring Google Analytics submissions

@LoneRifle LoneRifle requested a review from liangyuanruo June 30, 2020 02:14
@LoneRifle LoneRifle force-pushed the chore/deps/server-tweaks branch 2 times, most recently from 21c74d4 to 9338ede Compare June 30, 2020 02:35
@LoneRifle LoneRifle changed the title build(deps): update uuid, validator, replace request build(deps): update uuid, validator, request Jun 30, 2020
@LoneRifle LoneRifle force-pushed the chore/deps/server-tweaks branch 2 times, most recently from f99fc90 to 7d6e2ce Compare June 30, 2020 02:44
@yong-jie yong-jie merged this pull request into develop Jun 30, 2020
@yong-jie yong-jie deleted the chore/deps/server-tweaks branch June 30, 2020 06:28
LoneRifle added a commit that referenced this pull request Jun 30, 2020
@LoneRifle
build(deps): update uuid, validator, request (#228)
3e7b296
@snyk-bot snyk-bot mentioned this pull request Apr 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

@liangyuanruo liangyuanruo Awaiting requested review from liangyuanruo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoneRifle @yong-jie