Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new link highlighting #234

Merged
merged 1 commit into from
Jun 30, 2020
Merged

fix: new link highlighting #234

merged 1 commit into from
Jun 30, 2020

Conversation

JasonChong96
Copy link
Contributor

@JasonChong96 JasonChong96 commented Jun 30, 2020 •
edited by LoneRifle
Loading

Problem

As of release 1.19, new links are not highlighted on users' url table. This is due to changes in backend response that were incompatible with the frontend implementation

Solution

Revert change in behavior in backend response.

Fixes #231

LoneRifle
LoneRifle approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

liangyuanruo
liangyuanruo reviewed Jun 30, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this technically breaks backwards compatibility right - should we detect the HTTP 200 OK on the frontend instead?

@LoneRifle
Copy link
Contributor

this technically breaks backwards compatibility right - should we detect the HTTP 200 OK on the frontend instead?

The revert strikes me as more useful than the current returning of jsonMessage. Would be helpful perhaps to keep.

@liangyuanruo liangyuanruo merged commit b013a41 into develop Jun 30, 2020
@liangyuanruo liangyuanruo deleted the fix-highlighting branch June 30, 2020 15:23
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo left review comments

@LoneRifle LoneRifle LoneRifle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-highlighting of newly-created shortlinks is not working
3 participants
@JasonChong96 @LoneRifle @liangyuanruo