Use HTTP 401 Unauthorized for invalid login attempts #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mail validation This affects the /otp and /verify routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When an invalid email is used to attempt login, a HTTP 401 Unauthorized should be returned instead of the default HTTP 400 Bad Request.
Solution
Configure the validation middleware to return HTTP 401 if custom Joi email validation fails, instead of handing the error off to Express's
next(error)as is the default.Deploy Notes
This is technically a breaking change, but necessary as we proceed to configure Cloudwatch alerts.