Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary info from search api #241

Merged
merged 2 commits into from
Jul 1, 2020
Merged

fix: remove unnecessary info from search api #241

merged 2 commits into from
Jul 1, 2020

Conversation

JasonChong96
Copy link
Contributor

@JasonChong96 JasonChong96 commented Jul 1, 2020 •
edited
Loading

Problem

The search API returns some properties that are unnecessary for search.

[Closes #235]

Solution

Change the api such that only info necessary are returned. i.e shortUrl, longUrl, description, contactEmail.

@liangyuanruo liangyuanruo merged commit 4241f4e into develop Jul 1, 2020
@liangyuanruo liangyuanruo deleted the remove-search-response-props branch July 1, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

@yong-jie yong-jie Awaiting requested review from yong-jie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unnecessary info from search API
2 participants
@JasonChong96 @liangyuanruo