feat: user message banner #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonChong96
requested review from
liangyuanruo and
yong-jie
and removed request for
liangyuanruo
|
I have updated staging env to contain the USER_MESSAGE env var |
|
Added screenshot for IE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need an additional way to notify link owners of any service degradation or any other important messages.
Solution
A banner for the user page that shows important messages to users.
The message is read from the USER_MESSAGE env_var.
Before & After Screenshots
AFTER:
Deploy Notes
New environment variables:
USER_MESSAGE: user message to be shown. It is optional and the banner will not be shown if this is empty or not supplied.