fix(nodemailer): use default value for maxMessages #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
maxMessages
is set atInfinity
, which encourages long-living SMTPconnections. This may not work well with services like AWS SES' SMTP
relays, whose machines are ephemeral and may be culled without notice.
Solution
Rely on nodemailer's default of 100 messages per [1]. This allows us
to discard and replace connections to better ensure we are talking to
a live connection. Problems with connection leaks were fixed in
nodemailer 6
References:
[1] - https://nodemailer.com/smtp/pooled/