Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display the link user is editing on edit link drawer #265

Merged
merged 1 commit into from
Jul 13, 2020
Merged

feat: display the link user is editing on edit link drawer #265

merged 1 commit into from
Jul 13, 2020

Conversation

xming13
Copy link
Contributor

@xming13 xming13 commented Jul 11, 2020 •
edited
Loading

Problem

Closes #180

Solution

Update according to the proposed design in #180 (comment)

Improvements:

  • Change buttonText prop in CopyButton to be optional, defaults to the url to copy if omitted.
  • Removed unused styles
  • Destructure props for CopyButton

Before & After Screenshots

BEFORE (Desktop):
image

AFTER (Desktop):
image

BEFORE (Mobile):
image

AFTER (Mobile):
image

LoneRifle
LoneRifle approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @yong-jie or @liangyuanruo care to have a look?

@liangyuanruo liangyuanruo merged commit f101984 into opengovsg:develop Jul 13, 2020
xming13 referenced this pull request in xming13/GoGovSG Aug 21, 2020
@xming13
feat: display the link user is editing on edit link drawer (#265)
0e8ced5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate which link the user is editing on edit link drawer
3 participants
@xming13 @liangyuanruo @LoneRifle