Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the SVG #27

Merged
merged 3 commits into from
Apr 10, 2020
Merged

Fix the SVG #27

merged 3 commits into from
Apr 10, 2020

Conversation

kylerwsm
Copy link
Contributor

@kylerwsm kylerwsm commented Apr 9, 2020

Problem

Closes #26.

Solution

Our previous fix to render QR code in .png format on FireFox required us to set a specified height and width, which has caused problems to the .svg side. The solution is to unset the specified height and width after rendering the .png format QR code.

Improvements:

  • Committed eslint format changes.

Before & After Screenshots

BEFORE:
image

AFTER:
image

@kylerwsm kylerwsm changed the base branch from master to develop April 9, 2020 19:58
@liangyuanruo liangyuanruo merged commit 34021ad into opengovsg:develop Apr 10, 2020
@LoneRifle LoneRifle mentioned this pull request Apr 13, 2020
Closed
@kylerwsm kylerwsm deleted the fix-the-svg branch April 13, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent SVG QR code sizes
2 participants
@kylerwsm @liangyuanruo