Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stats): implement graphs and charts for link statistics #278

Merged
merged 15 commits into from
Jul 28, 2020

Conversation

kylerwsm
Copy link
Contributor

@kylerwsm kylerwsm commented Jul 20, 2020

Problem

This PR is the frontend portion for the Link Analytics feature.

Closes #55.

Solution

The charts are implemented using plain React, Chart.js, and React-Vis. Specifically, the device clicks statistics is done in plain React, the Daily Clicks Statistics is done in Chart.js, and the HeatMap Statistics is done using React-Vis.

TODO

  • Break down link statistics API to dedicated APIs for each chart
  • Put graphs into tabs

Before & After Screenshots

AFTER:
This will be updated when TODOS are completed.

Deploy Notes

Notes regarding deployment of the contained body of work. These should note any
new dependencies, new scripts, etc.

New dependencies:

  • react-chartjs-2 : React wrapper for chart.js
  • chart.js : Peer dependency required by react-chartjs-2
  • react-vis: Library tentatively used to render heatmap

@kylerwsm kylerwsm changed the title Stats graphs feat(stats): implement graphs and charts for link statistics Jul 20, 2020
@kylerwsm kylerwsm force-pushed the stats-graphs branch 2 times, most recently from f0fe2da to 9c43ca7 Compare July 28, 2020 04:37
@kylerwsm kylerwsm marked this pull request as ready for review July 28, 2020 05:54
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, reviewed with kyler on discord

@liangyuanruo liangyuanruo merged commit fcd7900 into develop Jul 28, 2020
@liangyuanruo liangyuanruo deleted the stats-graphs branch July 28, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link click history
3 participants