Enforce no-cache behaviour via Cache-Control header #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 13, 2020
liangyuanruo
approved these changes
Apr 13, 2020
|
Have confirmed that this solves the sign-out-not-working issue on IE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Browsers are unnecessarily caching resources and server responses.
This results in
bundle.jsbeing momentarily outdated on new redeployments. IE's behaviour of caching responses without revalidation also creates problems because even after signing out, it still mistakenly thinks it is still logged in due to outdated auth-check responses.Closes #4 and closes #5 .
Solution
Send
Cache-Control: no-storeheader for every outgoing response. This is implemented using a middleware that is inserted very early in the pipeline, right beforeexpress.staticis being used. This allows evenbundle.jsto be not be cached.