fix: explicit parsing config on query #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyuanruo
approved these changes
Jul 22, 2020
On production there's a link description that includes "Introduction" but it did not appear when searching "Introduction". I found that by searching it only appears when i searched for its root word "Introduct" which means that the query words weren't being stemmed according the the english config. Confirmed on staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While the default configuration for parsing queries is set to english on most database configurations and on the local docker image, it might be different in production environments.
For example, in AWS RDS, the default is set to
simplewhich does not stem query words.Solution
Explicitly state that the configuration to use in the query is
english