feat(upload): only allow some file types #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use file-type and inspection of extension to determine whether a file can be uploaded - Bring in file-type as a dependency - Implement FileTypeFilterService and drop into FileCheckController - Provide test coverage
LoneRifle
force-pushed
the
feat/upload/allow-extensions
branch
from
22a4691 to
2b28b89
Compare
LoneRifle
added a commit
that referenced
this pull request
Jul 24, 2020
Use file-type and inspection of extension to determine whether a file can be uploaded - Bring in file-type as a dependency - Implement FileTypeFilterService and drop into FileCheckController - Provide test coverage
yong-jie
pushed a commit
that referenced
this pull request
Jul 28, 2020
Use file-type and inspection of extension to determine whether a file can be uploaded - Bring in file-type as a dependency - Implement FileTypeFilterService and drop into FileCheckController - Provide test coverage
xming13
referenced
this pull request
in xming13/GoGovSG
Aug 21, 2020
Use file-type and inspection of extension to determine whether a file can be uploaded - Bring in file-type as a dependency - Implement FileTypeFilterService and drop into FileCheckController - Provide test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To influence user behaviour, only allow certain types of files to be uploaded
Solution
Use file-type and inspection of extension to determine whether
a file can be uploaded