Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: some simple fixes that were generating react errors #307

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

cliffkoh
Copy link
Contributor

Problem

What problem are you trying to solve? What issue does this close?

Closes [N/A]

Solution

Adds key attribute in a couple of places.

Bug Fixes:

Fixes a couple of react errors

Before & After Screenshots

BEFORE:

image

AFTER:
image

Tests

N/A

Deploy Notes

Notes regarding deployment of the contained body of work. These should note any
new dependencies, new scripts, etc.

New environment variables:
N/A

New scripts:
N/A
New dependencies:

N/A

New dev dependencies:

N/A

Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - @yong-jie , @kylerwsm - no issues I hope?

@LoneRifle LoneRifle requested a review from yong-jie July 24, 2020 12:03
@LoneRifle
Copy link
Contributor

LoneRifle commented Jul 27, 2020

This PR seems straightforward enough, so I am going ahead to merge it. Thanks for submitting this @cliffkoh!

@LoneRifle LoneRifle merged commit e4dd76c into opengovsg:develop Jul 27, 2020
@cliffkoh cliffkoh deleted the cliffkoh/simplefixes branch July 27, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants