Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump nanoid from 2.0.3 to 3.1.10" #325

Merged

Conversation

LoneRifle
Copy link
Contributor

Problem

#288 caused IE11 compatibility to break, as nanoid 3.x was implemented using arrow functions

Solution

Fall back on nanoid 2.x for now, until we figure out what to do for IE11

@LoneRifle LoneRifle requested a review from yong-jie July 29, 2020 06:35
@LoneRifle LoneRifle merged commit bde7695 into release-1.25.0 Jul 29, 2020
@LoneRifle LoneRifle deleted the revert-288-dependabot/npm_and_yarn/nanoid-3.1.10 branch July 29, 2020 06:36
xming13 pushed a commit to xming13/GoGovSG that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants