Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add documentation for search methods #329

Merged
merged 3 commits into from
Jul 30, 2020
Merged

docs: add documentation for search methods #329

merged 3 commits into from
Jul 30, 2020

Conversation

JasonChong96
Copy link
Contributor

Problem

Some search methods lack documentation.

Solution

Add documentation for said methods.

@JasonChong96 JasonChong96 requested a review from yong-jie July 29, 2020 09:34
LoneRifle
LoneRifle approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. For future reference, @param and @returns are meant to be labels, so punctuation not really needed.

@JasonChong96 JasonChong96 merged commit 37a546e into develop Jul 30, 2020
@LoneRifle LoneRifle deleted the url-repo-doc branch August 12, 2020 10:19
xming13 pushed a commit to xming13/GoGovSG that referenced this pull request Aug 21, 2020
@JasonChong96 @xming13
docs: add documentation for search methods (opengovsg#329)
b75632d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

@liangyuanruo liangyuanruo Awaiting requested review from liangyuanruo

@yong-jie yong-jie Awaiting requested review from yong-jie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonChong96 @LoneRifle @yong-jie