-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source the Maps #33
Merged
Merged
Source the Maps #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyuanruo
requested changes
Apr 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Have you tested? Also please rebase (or start working on this repo itself instead of using a fork)
Branch seems to be up to date already. Added new environment variables to |
liangyuanruo
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Modified webpack to generate sourcemaps while bundling, and implemented the uploading of sourcemaps to Sentry on production and staging builds.
Edit: Updated
README.md
with new environment variables.Closes #28.
Solution
On gogovsg, the build is done twice, once on Travis and another one via the dockerfile. This solution only builds and upload sourcemaps while building on Travis.
The workflow is webpack will check whether all the required environment variables for Sentry sourcemap upload are defined. If they are defined, webpack will include an additional plugin, that will help us to upload the sourcemap, to its list of plugins. I have done this as the build will fail if the Sentry webpack plugin is included without all the relevant environment variables defined.
I also added logs that will be printed during builds for our own sanity checks.
Improvements:
Deploy Notes
New environment variables:
The following environment variables have been defined on Travis:
SENTRY_AUTH_TOKEN
: (Secret) To get permissions to write the source maps.SENTRY_DNS
: The relevant Sentry DNS.SENTRY_ORG
: Our Sentry organisation name.SENTRY_PROJECT
: The relevant Sentry project (production, staging, etc.).SENTRY_URL
: The Sentry url.New dev dependencies:
@sentry/webpack-plugin
: The relevant package that helps us to upload our webpack sourcemaps to Sentry.