Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(404-page): add sg crest banner #375

Merged
merged 1 commit into from
Aug 7, 2020
Merged

feat(404-page): add sg crest banner #375

merged 1 commit into from
Aug 7, 2020

Conversation

yong-jie
Copy link
Member

@yong-jie yong-jie commented Aug 6, 2020

Problem

The not-found page does not have the SG govt banner at the top, which is an inconsistency in design as all other pages have it.

Solution

Follow SGDS's masthead guidelines

Before & After Screenshots

AFTER:
image

Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit 60cda91 into develop Aug 7, 2020
@LoneRifle LoneRifle deleted the 404-page-header branch August 12, 2020 10:19
xming13 pushed a commit to xming13/GoGovSG that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants