fix(file-upload): race condition caused by not awaiting a DB promise #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyuanruo
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Replace file does not update the file extension in the UI.
Closes #261
Solution
There was a race condition between the server-side update of the longUrl and the subsequent retrieval of all urls made by the client.
Because we did not await the promise, it returns a success to the client very early (before the update operation completes in the database). This prompts the client to initiate its next step: retrieve all urls and update its redux state. Because the database update operation isnt completed yet, the server returns the old state of urls, causing this bug.
The fix was to await the promise.