Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove props drilling tech debt in url-creation components #410

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

yong-jie
Copy link
Member

Problem

Some tech debt was incurred during development/refactors while building recent features. One of which is the deep levels of props drilling which can be solved using redux

Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yong-jie yong-jie merged commit 4ac4ea4 into develop Aug 14, 2020
@yong-jie yong-jie deleted the userpage-remove-prop-drilling branch August 14, 2020 05:13
xming13 pushed a commit to xming13/GoGovSG that referenced this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants