refactor(links): extract LinkInfoEditor #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the parts in the link control panel dealing with link info into a reusable component, to be used in the post-creation modal later - Move ConfigOption and DrawerTextField into UserPage widgets - Extract LinkInfoEditor from ControlPanel, propagating changes in state in contact emails and description back to parent using callbacks and `useEffect()` hooks - Change emailValidator to have a boolean primitive return type, remove from `useShortLink()` return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of work for #399, we have to refactor parts of the codebase to encourage reuse
Solution
Extract the parts in the link control panel dealing with link info
into a reusable component, to be used in the post-creation modal later
state in contact emails and description back to parent using
callbacks and
useEffect()hooksremove from
useShortLink()return valueTests
Exercise inputting of link information