Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otp): include request ip address in otp email #430

Merged
merged 8 commits into from
Aug 19, 2020
Merged

feat(otp): include request ip address in otp email #430

merged 8 commits into from
Aug 19, 2020

Conversation

yong-jie
Copy link
Member

@yong-jie yong-jie commented Aug 18, 2020 •
edited
Loading

Problem

We need to allow public officers to quickly trace who attempted to log in to their account for further investigation.

Closes #421

Solution

Pass the request IP into the email service to be added into the OTP mail text.

Before & After Screenshots

BEFORE:
image

AFTER:
image

liangyuanruo
liangyuanruo requested changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a getIp function that takes care of extracting the correct IP

LoneRifle
LoneRifle approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/server/services/email.ts Outdated Show resolved Hide resolved
liangyuanruo
liangyuanruo reviewed Aug 19, 2020
View reviewed changes
src/server/util/ip.ts Outdated Show resolved Hide resolved
liangyuanruo
liangyuanruo requested changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename or refactor if necessary to make the function more prominent to other developers.

@yong-jie
Copy link
Member Author

changes requested have been made. also edited the wording and removed instances of gogovsg as per @LoneRifle's request.

image

@yong-jie yong-jie requested a review from liangyuanruo August 19, 2020 07:40
liangyuanruo
liangyuanruo approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liangyuanruo liangyuanruo merged commit e8a29bb into develop Aug 19, 2020
@liangyuanruo liangyuanruo deleted the ip-in-otp-email branch August 19, 2020 08:00
xming13 pushed a commit to xming13/GoGovSG that referenced this pull request Aug 21, 2020
@yong-jie @xming13
feat(otp): include request ip address in otp email (opengovsg#430)
a5af1b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

@liangyuanruo liangyuanruo liangyuanruo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTP email to include requestor's IP address
3 participants
@yong-jie @liangyuanruo @LoneRifle