fix(search): omit most params in querystring if default #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- copy newParams in redirectWithParams, ensuring that query is always populated - for each param in newParams, if its value differs from default, populate in the copy. This results in an object omitting defaults from the querystring
xming13
pushed a commit
to xming13/GoGovSG
that referenced
this pull request
Aug 21, 2020
- copy newParams in redirectWithParams, ensuring that query is always populated - for each param in newParams, if its value differs from default, populate in the copy. This results in an object omitting defaults from the querystring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #323
Solution
newParamsinredirectWithParams(), ensuring that queryis always populated
newParams, if its value differs from default,populate in the copy. This results in an object omitting defaults
from the querystring
Before & After Screenshots