Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(file-upload): cloudmersive failures now return HTTP 400 Bad Request to client #462

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

liangyuanruo
Copy link
Contributor

@liangyuanruo liangyuanruo commented Aug 21, 2020

Problem

Using HTTP 500 Internal Server Error presumes that the problem lies with the server; however
Cloudmersive is clearly rejecting the file as a client error.

Solution

Change the HTTP Status Code returned and updated the response message.

…Request to client

Using HTTP 500 Internal Server Error presumes that the problem lies with the server; however
Cloudmersive is clearly rejecting the file as a client error.
@liangyuanruo liangyuanruo requested a review from LoneRifle August 21, 2020 07:32
@liangyuanruo liangyuanruo requested a review from LoneRifle August 23, 2020 06:57
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LoneRifle LoneRifle merged commit ba59aa1 into develop Aug 24, 2020
@liangyuanruo liangyuanruo deleted the cloudmersive-status branch August 24, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants