Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(links): redesign create URL modal #470

Merged
merged 24 commits into from
Sep 1, 2020
Merged

feat(links): redesign create URL modal #470

merged 24 commits into from
Sep 1, 2020

Conversation

yong-jie
Copy link
Member

@yong-jie yong-jie commented Aug 24, 2020 •
edited by LoneRifle
Loading

Problem

The number of links with descriptions and contact details are low. One way we to address this would be to prompt users to add them after creating their links. This PR serves to redesign the create-url-modal to do that.

Closes #399

Solution

  • Prevent modal from closing after url-create-success
  • Introduce the notion of steps within create-url-modal to conditionally show the add-description fields
  • Wire up the add-description reusable widget into create-url-modal via a wrapper component
  • Add 'submit' and 'skip' buttons in add-description stage
  • API call for edit description on submission
  • API call for isSearchable toggle
  • Swap button order in mobile view
  • Display newly-created url in modal
  • Fix the problem where the bottom banner blocks buttons in mobile view
  • Save button should have grey background grey when disabled

Before & After Screenshots

AFTER:
image
image

@yong-jie yong-jie force-pushed the create-url-modal-redesign branch from cf5214c to 5c3980d Compare August 24, 2020 06:42
yong-jie added 20 commits August 31, 2020 22:43
@yong-jie
refactor(CreateUrlModal): use history hook instead of prop drilling
aa04384
@yong-jie
refactor(CreateUrlModal): move file submission prop to parent
2785a98 
For state management purposes
@yong-jie
feat(CreateUrlAction): make promises return result of api call
850265d
@yong-jie
feat(CreatUrlModal): decorate submit actions
a4c9a49
@yong-jie
feat(CreateUrlAction): do not close modal upon success
85dfa7b
@yong-jie
refactor(CreateUrlModal): remove unused comment
89a321d
@yong-jie
feat(CreateUrlModal): reset step when opening and closing modal
ada0435
@yong-jie
feat(CreateUrlModal): conditional header text
e715042
@yong-jie
feat(CreateUrlModal): change conditional header text
decdb10
@yong-jie
feat(CreateUrlModal): add description step
4779789
@yong-jie
feat(CreateUrlModal): conditional rendering of Link Information text
6d91ec5
@yong-jie
fix(CreateUrlModal): ui race condition on modal state
f099d01
@yong-jie
feat(CreateUrlModal): add incomplete submit and skip buttons
85e6ef2
@yong-jie
feat(CreateUrlModal): add disable logic for save button
db061da
@yong-jie
feat(CreateUrlModal): dispatch closeModal action on skip
29fb235
@yong-jie
feat(CreateUrlModal): add api call for edit link description
267105d
@yong-jie
fix(CreateUrlModal): button background when disabled
5ab10b8
@yong-jie
fix(CreateUrlModal): add bottom margin to give space to banner
962f41f
@yong-jie
fix(CreateUrlModal): reverse button flex direction in mobile view
880ce59
@yong-jie
feat(CreateUrlModal): show shortUrl in modal
aa8fba4
@yong-jie yong-jie force-pushed the create-url-modal-redesign branch from cc7b629 to aa8fba4 Compare August 31, 2020 14:43
@yong-jie yong-jie marked this pull request as ready for review August 31, 2020 19:09
@yong-jie yong-jie changed the title [WIP] Create url modal redesign Create url modal redesign Aug 31, 2020
LoneRifle
LoneRifle approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider aggregating your commits so that they are easier to follow in future. Paras, not sentences

@LoneRifle LoneRifle changed the title Create url modal redesign feat(links): redesign create URL modal Sep 1, 2020
@yong-jie yong-jie merged commit 070d340 into develop Sep 1, 2020
@yong-jie yong-jie deleted the create-url-modal-redesign branch September 1, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add toggle for public/private links and link description modal after create links
2 participants
@yong-jie @LoneRifle