feat(links): allow links to be marked as searchable #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoneRifle
changed the title
LoneRifle
force-pushed
the
feat/links/searchable
branch
4 times, most recently
from
1dcea7b to
6f123a5
Compare
LoneRifle
changed the title
LoneRifle
force-pushed
the
feat/links/searchable
branch
from
7e3c274 to
089fd28
Compare
Right now, links are indexed by default. Allow users to explicitly mark their links as searchable, defaulting to false, so that users are not surprised by links implicitly made searchable. - Declare `isSearchable` as a boolean field on the Url table, and equivalent fields on corresponding types - Replace `description` with `isSearchable` in GIN index - Add appropriate plumbing to both server and client so that `isSearchable` is propagated throughout the application
- Move GoSwitch for use by LinkInfoEditor - Add more plumbing in redux/etc to supply `isSearchable` - Render `isSearchable` as a toggle switch in LinkInfoEditor
LoneRifle
force-pushed
the
feat/links/searchable
branch
from
089fd28 to
c8eb7c4
Compare
LoneRifle
force-pushed
the
feat/links/searchable
branch
from
3b79c3a to
2c88db2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem and Solution
Right now, links are indexed by default. Allow users to explicitly
mark their links as searchable, defaulting to false, so that users
are not surprised by links implicitly made searchable.
isSearchableas a boolean field on the Url table, andequivalent fields on corresponding types
descriptionwithisSearchablein GIN indexisSearchableis propagated throughout the applicationPart of work for #399
Screenshots
Deploy Notes
isSearchablewill have to be added as a new boolean column in urls table, non-null, default falseisSearchable