-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid race condition in LoginPage component #49
Conversation
Release 1.13.2 - Landing page tweaks, SVG QR codes for IE11
Release 1.13.3 - Documentation and bug fixes
Release 1.13.4 - Send Sentry source-maps on travis build step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As stated here, #48 (comment), the implementation is injected server side because we prefer to be able to update the displayed message without code changes.
That said, we are happy to accept a PR that resolves the race condition brought up in the issue.
@liangyuanruo makes sense. I'm just trying to wrap my head around your comment. Does this mean if you change an environment variable in production, you wont have to re-deploy to reflect the changes? Express picks it up instantly? 🤔 |
No, it means that changing the message is considered a system configuration, which does not require a code commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, code looks good to me. Final thing - could you switch the pull request target to develop
? That is our development mainline, and we will perform a merge into master
for our next release cycle.
Closes #48
Changes:
Screenshots:
When refreshing the User page: