test(services): add tests for services #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor CloudmersiveScanService's dependencies so that they can be injected at runtime by inversify, rather than imported. This makes testing easier since we would not have to mess around with building mock classes for ScanApi - Implement a comprehensive test for CloudmersiveScanService
LoneRifle
force-pushed
the
test/services
branch
from
36cc54b to
366b612
Compare
`isThreat()` was evaluated as `safeBrowsingLogOnly && matches`. This is incorrect as we want the result to always be false when `safeBrowsingLogOnly`, and to be influenced by matches when `!safeBrowsingLogOnly`. Correct this typo so that we can correctly report SafeBrowsing results to the user. Provide coverage test as part of the work done.
yong-jie
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide test coverage for services