Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(transition): copy apple-touch-icon from index.html #501

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

LoneRifle
Copy link
Contributor

Problem and Solution

Browsers eagerly guess the path for apple-touch-icon, triggering 404 alarms for popular links.
Add a proper reference to what we have, copied from index.html.

@LoneRifle LoneRifle requested a review from liangyuanruo August 31, 2020 03:56
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks straightforward lgtm

@LoneRifle LoneRifle merged commit 3e09705 into develop Aug 31, 2020
@yong-jie yong-jie deleted the chore/transition/apple-touch-icon branch September 8, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants