Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump @typescript-eslint to 4.0.1 #522

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Sep 1, 2020

  • Pick up new rules for no-shadow from @typescript-eslint
  • Disable no-shadow in favour of @typescript-eslint equivalent
  • Ensure that @typescript-eslint recognises DOM globals by setting
    parserOptions.lib
  • Reorder type definitions to avoid no-use-before-define
  • Properly pick up sequelize types in test mocks

Signed-off-by: dependabot[bot] <support@github.com>
@LoneRifle
Copy link
Contributor Author

@dependabot rebase

@LoneRifle LoneRifle marked this pull request as ready for review September 3, 2020 08:38
@LoneRifle LoneRifle requested a review from yong-jie September 3, 2020 08:38
- Pick up new rules for no-shadow from @typescript-eslint
- Disable no-shadow in favour of @typescript-eslint equivalent
- Ensure that @typescript-eslint recognises DOM globals by setting
  `parserOptions.lib`
- Reorder type definitions to avoid no-use-before-define
- Properly pick up sequelize types in test mocks
@LoneRifle LoneRifle force-pushed the dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-4.0.0 branch from 5a8cc66 to 70b2ed9 Compare September 3, 2020 08:40
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Hopefully it doesnt break our build this time 🙏

@LoneRifle LoneRifle merged commit 367d599 into develop Sep 7, 2020
@yong-jie yong-jie deleted the dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-4.0.0 branch September 8, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants