Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): remove sinon as a dependency #541

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

LoneRifle
Copy link
Contributor

Problem and Description

Remove sinon as a dependency as we already have jest and jest.fn(). This reduces the number of dependencies we have to keep track of.

@LoneRifle LoneRifle requested a review from yong-jie September 7, 2020 03:40
@liangyuanruo liangyuanruo merged commit 49f31fa into develop Sep 8, 2020
@liangyuanruo liangyuanruo deleted the refactor/deps/no-sinon branch September 8, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants