Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(services): add coverage for UrlManagementService #553

Merged
merged 3 commits into from
Sep 9, 2020
Merged

test(services): add coverage for UrlManagementService #553

merged 3 commits into from
Sep 9, 2020

Conversation

LoneRifle
Copy link
Contributor

Problem and Solution

As part of routine work to ensure code correctness, add test coverage for UrlManagementService

@LoneRifle LoneRifle requested a review from yong-jie September 8, 2020 11:03
@yong-jie
fix(gh-actions): run CI jobs on pull_request action
c81316e
@yong-jie
fix(gh-actions): do not run CI on pull_request synchronized event
f7d55dc 
This is because the `push` event already gets triggered, so it becomes
a double run.
yong-jie
yong-jie approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I've also pushed a fix to gh-actions. Note that the config omits the pull_request.synchronize event to prevent duplicate workflows (both synchronize & push) from being launched when a commit is added into an existing PR.

test/server/services/UrlManagementService.test.ts Show resolved Hide resolved
@LoneRifle LoneRifle merged commit 08be377 into develop Sep 9, 2020
@LoneRifle LoneRifle deleted the test/services/url-management branch September 9, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yong-jie yong-jie yong-jie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LoneRifle @yong-jie