Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csp): add https: prefix, / suffix #560

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Conversation

LoneRifle
Copy link
Contributor

Problem and Solution

CSP implementations vary across browsers, so accommodate
them by fully specifying the URL, not just the hostnames

src/server/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@liangyuanruo liangyuanruo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented

CSP implementations vary across browsers, so accommodate
them by fully specifying the URL, not just the hostnames
@LoneRifle LoneRifle merged commit 9dcef07 into develop Sep 9, 2020
@LoneRifle LoneRifle deleted the fix/csp/add-https branch September 9, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants