Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui of transition page #589

Merged
merged 3 commits into from
Sep 15, 2020
Merged

fix: ui of transition page #589

merged 3 commits into from
Sep 15, 2020

Conversation

Oxiang
Copy link
Contributor

@Oxiang Oxiang commented Sep 15, 2020

Problem

The banner is too close to the header in the mobile version.
Also, in mobile version, the text in the hyperlink tag should be broken down into 2 lines

Closes #588

How did you solve the problem?

Changed the css height to provide more space and attached a break in between the 2 sentences that only breaks in mobile version

Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the .DS_Store files that have been introduced here

@LoneRifle LoneRifle self-requested a review September 15, 2020 07:13
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Include screenshots demonstrating your frontend work in future. merge when ready.

Copy link
Member

@yong-jie yong-jie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is lgtm. merge when ready

@Oxiang Oxiang merged commit 38cc771 into develop Sep 15, 2020
@yong-jie yong-jie deleted the transition-edit branch September 15, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abnormal spacing between elements in current transition page UI
3 participants