fix: go logo intersects with redirect link #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will do a more thorough discussion/review tomorrow. I wonder how the UI looks if we were to reduce the height of the viewport even further. Should we also consider the option of switching the UI to a mobile version (where the blue-white background split is at 35vh) when the height is too short? |
yong-jie
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GO Logo intersects with the redirect link
Solution
Resolved using CSS. Underneath the image, is there a margin of 24px which causes the logo to intersect with the redirect link when screen height compress. Moving the selector to only trigger in mobile seem to stop that.
##Images
-before
-after
