Proposal to allow user to OTP if mailing fails in development #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In development mode, we are using
nodemailer-direct-transport
to mail OTPs. But it does not provide consistent mailing performance across different IP addresses. Some IPs addresses may be blacklisted from outbound mailing resulting in errors like this. In these cases, developers may not be able to proceed to the OTP and user pages without making code changes.Since we have a default OTP for local development, and
nodemailer-direct-transport
is a local development only issue, I thought that creating allowing users to proceed to OTP even if mailing fails in development may be appropriate and helpful.Solution
When there is a mail error, I added a conditional statement that checks if the environment is a development environment. If it is, the server responses with an
ok
status after printing some relevant warning logs.