Allow S3 object ACL to be toggled when a shortlink is activated/deactivated #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75cbf17.
liangyuanruo
reviewed
May 5, 2020
liangyuanruo
reviewed
May 5, 2020
liangyuanruo
reviewed
May 5, 2020
liangyuanruo
reviewed
May 5, 2020
|
sry this PR doesnt work properly on staging, will convert to draft first to fix |
|
Changes requested have been made. Issues that surfaced during a test on staging have also been fixed, making this PR ready for review. |
liangyuanruo
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need a way to toggle the visibility of the s3 object. This is because our bucket defaults to
private. After a short link has been reserved and the file has been uploaded to S3, the client will need to call the edit-url-state endpoint once to trigger this hook, setting the s3 object tovisible.Solution
Use a hook in the active/inactive edit API endpoint to also toggle the visibility of the S3 object, if the url has
isFileset totrue