feat(links): disclose owner on dup creation #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoneRifle
force-pushed
the
feature/links/disclose-owner
branch
from
42300bc to
1bce502
Compare
If the user attempts to create a link that already exists, disclose the owner's e-mail - Declare and implement `UserRepository.findUserByUrl()` - Lookup owner if link already exists on creation, and disclose e-mail to user
LoneRifle
force-pushed
the
feature/links/disclose-owner
branch
from
1bce502 to
1fc6f14
Compare
|
@opengovsg/gosg-engineers could someone have a look? |
liangyuanruo
requested changes
Sep 29, 2020
LoneRifle
force-pushed
the
feature/links/disclose-owner
branch
from
d130481 to
5e12ca5
Compare
liangyuanruo
approved these changes
Sep 30, 2020
yong-jie
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is not obvious to the user who they should speak to
when a link they are trying to create already exists. They
often have to turn to support, which then would have to do a
manual lookup via a database query.
Solution
If the user attempts to create a link that already exists,
disclose the owner's e-mail
UserRepository.findUserByUrl()to user
Screenshot