fix line height bug in iPhone 6/7 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reiallenramos
changed the title
kylerwsm
suggested changes
May 5, 2020
There was a problem hiding this comment.
Thanks for the proposed fix, however, I noticed that if the text field is empty, it will look like the below screenshot, with the start adornment and textfield placeholder text slightly misaligned. I believe this is because of the difference in line-height of the two elements. Adding a line-height: 1.5 in the input object in styles/CreateUrlModal.js should solve this issue.
Since you are on it, can you look into that? Thanks!
|
Thanks! Should be okay now 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
text in input are cut off in iPhone 7 and lower
Closes #3
Solution
specify input
heightBefore & After Screenshots
BEFORE:
AFTER:
Notes:
Checked desktop behavior to ensure it still works.