Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OGP footer #652

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Add OGP footer #652

merged 1 commit into from
Sep 29, 2020

Conversation

Oxiang
Copy link
Contributor

@Oxiang Oxiang commented Sep 28, 2020

Problem

Modifying the existing footer to include OGP logo (light) and words (a division of Govtech)

#587

Solution

  • remove ogp icon in existing footer
  • added svg for ogp, linkedin and facebook icons
  • added ogp logo, white version (light)
  • set up widget for new icons
  • set up new, bottom footer
  • added grey color for typography caption
  • added black background color
  • added links & edited copyright in translation

Features:

  • added new dark footer to the bottom of the existing footer

Before & After Screenshots

BEFORE:
dekstop view:
before_desktop_view

mobile view:
before_mobile_view

AFTER:
desktop view:
desktop_view

mobile view:
mobile_view

- added svg for ogp, linkedin and facebook icons
- added ogp logo, white version
- set up widget for new icons
- set up new low footer
- added grey color for typography caption
- added black background color
- added links & edit copyright in translation
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants