Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp CreateUrlModal #67

Merged
merged 14 commits into from
May 8, 2020
Merged

Revamp CreateUrlModal #67

merged 14 commits into from
May 8, 2020

Conversation

kylerwsm
Copy link
Contributor

@kylerwsm kylerwsm commented May 5, 2020

Problem

Revamp the CreateUrlModal dialog. Apart from the different look, it is now also full-screen on small devices.

Solution

  • Rather than using a Modal, CreateUrlModal now uses a Dialog, which is a MUI component built on Modal. It serves our purpose better with helpful built-in props to control full-screen and max-width.

  • The EmptyState component is drafted in this PR but is not yet used by any components.

Improvements:

  • Improved the embed Google Font link used in index.html to download more italic font weights. Using the previous embed link, applying italics to a normal font weight character will also bold it.

  • Fixed stylings in our initial custom theme, i.e. body2 font size was larger than body1.

  • Progressively converting component stylings to make use the makeStyles hook in order to use dynamic props. Also, structuring components to be single-file/single-directory components.

After Screenshots

AFTER:
Screenshot 2020-05-05 at 11 14 49 PM
Screenshot 2020-05-05 at 11 15 03 PM

Tests

Create new short urls on both the full-screen dialog on mobile view and the normal dialog on desktop view to confirm its functionality.

@kylerwsm kylerwsm marked this pull request as ready for review May 5, 2020 16:29
@kylerwsm kylerwsm requested review from liangyuanruo and yong-jie May 5, 2020 16:29
@yong-jie
Copy link
Member

yong-jie commented May 8, 2020

Regarding your draft implementation of empty state, just to check, that's the UI to show when there are currently no links to display for a given user right?

@kylerwsm
Copy link
Contributor Author

kylerwsm commented May 8, 2020

Regarding your draft implementation of empty state, just to check, that's the UI to show when there are currently no links to display for a given user right?

Yes, you are right. But EmptyState will not be used until the table revamp.

@liangyuanruo liangyuanruo merged commit 651972f into develop May 8, 2020
@liangyuanruo liangyuanruo deleted the user-page branch May 8, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants