-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp CreateUrlModal #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding your draft implementation of empty state, just to check, that's the UI to show when there are currently no links to display for a given user right? |
Yes, you are right. But |
liangyuanruo
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Revamp the
CreateUrlModal
dialog. Apart from the different look, it is now also full-screen on small devices.Solution
Rather than using a
Modal
,CreateUrlModal
now uses aDialog
, which is a MUI component built onModal
. It serves our purpose better with helpful built-in props to control full-screen and max-width.The
EmptyState
component is drafted in this PR but is not yet used by any components.Improvements:
Improved the embed Google Font link used in
index.html
to download more italic font weights. Using the previous embed link, applying italics to a normal font weight character will also bold it.Fixed stylings in our initial custom theme, i.e.
body2
font size was larger thanbody1
.Progressively converting component stylings to make use the
makeStyles
hook in order to use dynamic props. Also, structuring components to be single-file/single-directory components.After Screenshots
AFTER:
Tests
Create new short urls on both the full-screen dialog on mobile view and the normal dialog on desktop view to confirm its functionality.