-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User page toolbar redesign and code improvements #69
Conversation
Quick query: i see that for imports there are some changes that remove paths like |
The relative paths are not a recommendation by prettier but a preference because of better refactor support from VSCode. I also understand the benefits in using absolute paths. I can change it back to absolute paths if that is more desirable. |
i've yet to test refactor for the |
src/client/components/UserPage/UserLinkTable/ToolBar/SearchInput/index.jsx
Show resolved
Hide resolved
src/client/components/UserPage/UserLinkTable/ToolBar/SearchInput/index.jsx
Show resolved
Hide resolved
src/client/components/UserPage/UserLinkTable/UrlTable/MemoTablePagination/index.jsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Force pushing to rebase to develop branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -83,7 +83,6 @@ export async function generateOtp(req: Express.Request, res: Express.Response) { | |||
} catch (error) { | |||
logger.error(`OTP generation failed unexpectedly:\t${error}`) | |||
res.serverError(jsonMessage('OTP generation failed unexpectedly.')) | |||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the only change since my last review.
Problem
User page toolbar redesign, and code de-coupling and improvements.
Solution
Improvements:
ApplyAppMargins
container component) App margin values are now exposed using theuseAppMargins
hook rather than thefetchAppMargins
function from before. Doing this allows the consumer components to better manipulate the app margins.tableTheme.js
intotheme.js
. As a result the link row slider now follows the app theme bluish color.Before & After Screenshots
BEFORE:
Before: Mobile view
AFTER:
After: Mobile view
Tests
Deploy Notes
New dependencies:
@types/lodash
: Type file for lodash