feat: remove link description #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hide link description in drawer - add announcement in drawer - skip link description modal on link creation
Oxiang
force-pushed
the
description-removal
branch
from
e67581a to
b442650
Compare
yong-jie
approved these changes
Oct 7, 2020
| @@ -72,7 +72,7 @@ const CreateUrlModal = ({ | |||
| const incrementDecorator = (func) => async (...args) => { | |||
| const proceed = await func(...args) | |||
| if (proceed) { | |||
| setStep(step + 1) | |||
There was a problem hiding this comment.
can consider just commenting the previous code out so in the future we know what we need to do to restore the old functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Hide and skip link description in drawer and link creation modal as GoSearch is put to hold
closes #673
closes #671
Solution
Drawer:
Link Creation Modal:
Skip link description modal during link creation
After Screenshots
Drawer - desktop (screenshot is broken down into 2 section by scrolling)
Drawer - mobile (screenshot is broken down into 3 section by scrolling)
Link Creation Modal - desktop
after clicking 'create link'
Link Creation Modal - mobile
after clicking 'create link'