feat: implement announcement modal #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inject the user message into UserController rather than getting it via the config module. This simplifies the corresponding test and will establish a consistent pattern when testing a future dependency, ie the user modal message - Declare userMessage as a dependency id - Inject userMessage via inversify into UserController as ctor param - Simplify the UserController test suite, dropping need for jest.mock
Allow a new env var - `USER_ANNOUNCEMENT` - to be specified at runtime, parsed into a simple JSON payload to be at `/api/user/announcement` - Declare `USER_ANNOUNCEMENT` at config, to be parsed into `userModal` - Inject `config.userAnnouncement` into UserController via inversify - Expose this via `/api/user/announcement` - Provide coverage tests that verify parsing and serving
LoneRifle
force-pushed
the
feat/modal
branch
2 times, most recently
from
ca3ed16 to
13f49cd
Compare
If there is a new response at `/api/user/announcement`, flash a modal at the user - Provide scaffolding for user announcements in Redux - Inject `USER_ANNOUNCEMENT` env var in docker-compose - Move `fullScreenDialog` helper to UserPage and reference it in AnnouncementModal - Fully flesh out AnnouncementModal, using localStorage to remember when a modal is last seen
- use multiple env vars, one for each field, rather than a single one - adjust button colour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #397
Solution
the config module. This simplifies the corresponding test and will
establish a consistent pattern when testing a future dependency, ie
the user modal message
parsed into a simple JSON payload to be at
/api/user/announcementANNOUNCEMENT_env vars in docker-composefullScreenDialoghelper to UserPage and reference it inAnnouncementModal
when a modal is last seen
Screenshots
Deploy Notes
New environment variables:
USER_ANNOUNCEMENT: a;-separated string that describes in sequence message, title, subtitle, url and path to image