bug: ellipsis for extra long shortened links #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jials
force-pushed
the
bug/ellipsis-extra-long-links
branch
from
3d34d2e to
e93eb4e
Compare
|
@LoneRifle Mind to help me to add a |
|
I assume that hacktoberfest should have picked up on the PR already, but ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When user create an extra long link, the user table will overflow and this pushes the other columns out of sight.
Closes #411
Solution
Set
maxWidth = 400pxto theshortUrldiv for viewport bigger thanmd. Also add tooltip to show the full URL when hover above the short URL.Before & After Screenshots
BEFORE:
AFTER:
