Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login graphic height fix #76

Merged
merged 2 commits into from
May 13, 2020
Merged

Login graphic height fix #76

merged 2 commits into from
May 13, 2020

Conversation

kylerwsm
Copy link
Contributor

Problem

On shorter desktop displays, the login page graphic may exceed the viewport height. The graphic does not look optimal this way. Furthermore, this affects the placement of the login form on the right as it is vertically aligned by percentage margins.

Solution

Added an additional style to limit the maximum height of the graphic.

Improvements:

  • Eslint code formatting.

Before & After Screenshots

BEFORE:
image

AFTER:
image

@kylerwsm kylerwsm requested review from liangyuanruo and yong-jie May 13, 2020 17:20
@liangyuanruo liangyuanruo merged commit bab6f14 into develop May 13, 2020
@liangyuanruo liangyuanruo deleted the login-tweak branch May 13, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants